Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LTI submission polling #1162

Closed
wants to merge 1 commit into from
Closed

Fix LTI submission polling #1162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lti_tool/templates/lti_tool/lti_submission.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
{% block siblings_bottom %}{% endblock %}
{% block footer %}{% endblock %}

{% block exercise_wait %}
{% include "lti_tool/_lti_exercise_wait.html" %}
{% endblock %}

{% block exerciseinfo %}
{{ block.super }}
{% include 'exercise/_submission_info.html' %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% include 'exercise/_submission_info.html' %}

Since this template inherits submission.html, {{ block.super }} already includes submission_info.html. Including it twice causes the same box to appear twice in the rendered html page.

{% include "lti_tool/_lti_exercise_wait.html" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think _lti_exercise_wait.html belongs to the exerciseinfo block. The exerciseinfo block is intended for the column on the right side of the exercise and submission pages.

Block exercise_wait is confusing since it is not defined at all in exercise_base.html or exercise.html. The purpose of the block exercise_wait needs to be checked. Perhaps, we will remove it completely also from submission.html.

{% endblock %}