Implement way of sending Acos grading results to LTI platform #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkuriekkinen
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Great, thanks! I will add the "fixes #1154" link to the git commit message and merge this pull request.
Short description of the implementation as a reminder:
- when the A+ front retrieves the exercise description from the exercise service, the HTTP GET request includes an extra parameter
lti_launch_idif the user's current session includes LTI parameters from an LTI v1.3 launch (to A+ as the LTI Tool). - The Aplus protocol at the Acos server (Add support for A+ LTI acos-server/acos-aplus#8) is modified so that it will store the LTI launch id parameter in the user's browser in a hidden HTML
<input>element. - Acos server forwards the LTI launch parameter to the A+ front when the exercise submission is sent to the Acos server.
- When A+ receives the graded submission from the Acos server, A+ stores the LTI launch id in the submission
meta_datafield. The LTI launch id is then used to send the grade to the LTI Platform.
| @@ -52,6 +52,12 @@ def _post_async_submission(request, exercise, submission, errors=None): | |||
| submission.feedback = form.cleaned_data["feedback"] | |||
| submission.grading_data = post_data | |||
|
|
|||
| # Acos-submissions initialize this as an empty string for some reason; fix here | |||
There was a problem hiding this comment.
The Submission.meta_data field uses our old custom JSONField that is simply a normal TextField with some extra JSON parsing. Thus, its default value is an empty string. In the case of Acos exercises, no value is set to the submission.meta_data field before this point. The submission is created here:
Line 128 in b36e145
When the A+ LTI Tool v1.3 feature was added in v1.18, there was no support yet for the LTI grading of Acos server assignments. Now, those grades can be sent to the LTI Platform. Short description of the implementation: - When the A+ front retrieves the exercise description from the exercise service, the HTTP GET request includes an extra parameter `lti_launch_id` if the user's current session includes LTI parameters from an LTI v1.3 launch (to A+ as the LTI Tool). - The Aplus protocol at the Acos server (acos-server/acos-aplus#8) is modified so that it will store the LTI launch id parameter in the user's browser in a hidden HTML `<input>` element. - Acos server forwards the LTI launch parameter to the A+ front when the exercise submission is sent to the Acos server. - When A+ receives the graded submission from the Acos server, A+ stores the LTI launch id in the submission `meta_data` field. The LTI launch id is then used to send the grade to the LTI Platform. Fixes apluslms#1154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This, combined with acos-server/acos-aplus#8, fixes an issue where A+ was unable to send points from ACOS back to the LTI platform when A+ was used as an LTI tool.
Fixes #1154
Testing
What type of test did you run?
Did you test the changes in