Protect against buggy participants reports from Aalto SISU API #1181
+22
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
It has turned out that Aalto's SISU API gateway occasionally returns an empty list for all courses queried using this API because of some malfunction. This causes all students to be removed from course enrollments (and a major hassle as a result). Therefore we have now added a check to the code to protect against this situation: if the response contains an empty participant list, it is ignored.
Additionally, the error handling now reports the error code more clearly in logs.
Fixes #1180
Testing
What type of test did you run?
This fix was not tested, because of the difficulty of doing that, but I assume there are no problems.
Did you test the changes in
Programming style
Have you updated the README or other relevant documentation?
Is it Done?