Add a 'GDPR compliant' LTIv1.3 service option #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an "outside EU but GDPR compliant" service option for LTIv1.3 services. Also added "sends_user_info" to LTI1p3Service since it always sends A+ user ID. Added an additional message clarifying that only A+ id is sent in LTI1p3Services when share_name == False, and templating logic for handling various configurations of is_anonymous and share_name. Also fixed a couple of typos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an "outside EU but GDPR compliant" service option for LTIv1.3 services. Also added "sends_user_info" to LTI1p3Service since it always sends A+ user ID.
Added an additional message clarifying that only A+ id is sent in LTI1p3Services when share_name == False, and templating logic for handling various configurations of is_anonymous and share_name.
Also fixed a couple of typos.
Why?
The warning message for global services was deemed intimidating, and some logic with LTI services was missing / incorrect based on what data is sent.
Fixes #1342
Testing
What type of test did you run?
Tried out various combinations of LTI and LTI1.3 services with share name on / off.