database/sql: fix memory leaks in Stmt.removeClosedStmtLocked

Zero out elements before shrinking the slice to avoid memory leaks. Fixes golang#66410.
apocelipes · Mar 20, 2024 · cbaf396 · cbaf396
1 parent f94d82b
commit cbaf396
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/database/sql/sql.go b/src/database/sql/sql.go
@@ -2684,6 +2684,8 @@ func (s *Stmt) removeClosedStmtLocked() {
 	for i := 0; i < len(s.css); i++ {
 		if s.css[i].dc.dbmuClosed {
 			s.css[i] = s.css[len(s.css)-1]
+			// Zero out last element (for GC) before shrinking the slice.
+			s.css[len(s.css)-1] = connStmt{}
 			s.css = s.css[:len(s.css)-1]
 			i--
 		}