Skip to content

Conversation

BlenderDude
Copy link
Member

@BlenderDude BlenderDude commented Aug 11, 2023

Closes #120

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

🦋 Changeset detected

Latest commit: 56fca54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@as-integrations/aws-lambda Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 11, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56fca54:

Sandbox Source
apollo-server-integration-aws-lambda Configuration

@BlenderDude BlenderDude merged commit d1e8271 into main Aug 11, 2023
@BlenderDude BlenderDude deleted the da/get-request-decode branch August 11, 2023 17:59
@github-actions github-actions bot mentioned this pull request Aug 11, 2023
@iiroj
Copy link

iiroj commented May 23, 2024

I believe this change causes issues for requests coming through an AWS API Gateway, because the API Gateway already decodes the parameters. Using difficult characters like % leads to double-decoding and produces a Malformed URI error with status code 400.

Is the intention that we manually encode them back before passing the event, or can this be considered a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET requests fail due to uri encoding
2 participants