refactor: #5236 test code

apolloconfig · Oct 6, 2024 · ff75da3 · ff75da3
1 parent acad9b7
commit ff75da3
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/.../java/com/ctrip/framework/apollo/configservice/filter/ClientAuthenticationFilterTest.java b/.../java/com/ctrip/framework/apollo/configservice/filter/ClientAuthenticationFilterTest.java
@@ -144,10 +144,7 @@ public void testAuthorizedSuccessfully() throws Exception {
 
     clientAuthenticationFilter.doFilter(request, response, filterChain);
 
-    verify(response, never()).sendError(HttpServletResponse.SC_BAD_REQUEST, "InvalidAppId");
-    verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "RequestTimeTooSkewed");
-    verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "Unauthorized");
-    verify(filterChain, times(1)).doFilter(request, response);
+    verifySuccessAndDoFilter();
   }
 
   @Test
@@ -168,10 +165,7 @@ public void testPreCheckInvalid() throws Exception {
 
     clientAuthenticationFilter.doFilter(request, response, filterChain);
 
-    verify(response, never()).sendError(HttpServletResponse.SC_BAD_REQUEST, "InvalidAppId");
-    verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "RequestTimeTooSkewed");
-    verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "Unauthorized");
-    verify(filterChain, times(1)).doFilter(request, response);
+    verifySuccessAndDoFilter();
     verify(clientAuthenticationFilter, times(2)).preCheckInvalidLogging(anyString());
   }
 
@@ -193,10 +187,14 @@ public void testPreCheckSuccessfully() throws Exception {
 
     clientAuthenticationFilter.doFilter(request, response, filterChain);
 
+    verifySuccessAndDoFilter();
+    verify(clientAuthenticationFilter, never()).preCheckInvalidLogging(anyString());
+  }
+
+  private void verifySuccessAndDoFilter() throws Exception {
     verify(response, never()).sendError(HttpServletResponse.SC_BAD_REQUEST, "InvalidAppId");
     verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "RequestTimeTooSkewed");
     verify(response, never()).sendError(HttpServletResponse.SC_UNAUTHORIZED, "Unauthorized");
     verify(filterChain, times(1)).doFilter(request, response);
-    verify(clientAuthenticationFilter, never()).preCheckInvalidLogging(anyString());
   }
 }