Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace中复制相同的内容再粘贴会清除原有内容 #4919

Closed
3 tasks done
BlueSodaWater opened this issue Jul 1, 2023 · 2 comments · Fixed by #4922
Closed
3 tasks done

Namespace中复制相同的内容再粘贴会清除原有内容 #4919

BlueSodaWater opened this issue Jul 1, 2023 · 2 comments · Fixed by #4922
Labels
bug Categorizes issue or PR as related to a bug. help wanted

Comments

@BlueSodaWater
Copy link
Contributor

BlueSodaWater commented Jul 1, 2023 •
edited
Loading

描述bug

Namespace中复制相同的内容再粘贴，编辑框中显示正常，但提交修改之后，原有内容会被清除

复现

通过如下步骤可以复现：

  1. 新建一个yml类型的Namespace
  2. 截取部分内容ctrl+c复制
  3. 将这部分内容原封不动粘贴到原内容中
  4. 点击修改按钮
  5. 点击提交，发现原有的内容变成空了

期望

如果内容相同覆盖掉就好而不是清除

截图

3c449d83-dfa2-4a97-ac5e-c382194851f0

额外的细节和日志

  • 版本：http://81.68.181.139/ 上可以复现，当前master分支也有这个问题
  • 错误日志
  • 配置：
  • 平台和操作系统
@BlueSodaWater
Copy link
Contributor Author

这个问题应该是和 #4483 是同样的，不过4483只是这个问题的部分场景，后续我看到了 #4486 的修复，应该也是仅仅局限于全部复制和粘贴然后导致为空的情况。

@BlueSodaWater
Copy link
Contributor Author

这个还是挺影响使用的，因为当要把测试环境的配置复制到生产环境的时候，配置很多并且有些长度很长的情况，很容易粘贴到相同的内容，一不小心就会把生产的配置给覆盖了，差点因此导致生产事故

BlueSodaWater pushed a commit to BlueSodaWater/apollo that referenced this issue Jul 1, 2023
Fix the issue that clear content when paste the same content in names…
32882d7 
…pace (apolloconfig#4919)
@BlueSodaWater BlueSodaWater mentioned this issue Jul 1, 2023
Closed
@nobodyiam nobodyiam added bug Categorizes issue or PR as related to a bug. help wanted labels Jul 2, 2023
BlueSodaWater pushed a commit to BlueSodaWater/apollo that referenced this issue Jul 2, 2023
Fix the issue that clear content when paste the same content in names…
97be1c6 
…pace (apolloconfig#4919)
BlueSodaWater added a commit to BlueSodaWater/apollo that referenced this issue Jul 2, 2023
@BlueSodaWater
Fix the issue that clear content when paste the same content in names…
c9f585b 
…pace (apolloconfig#4919)
@BlueSodaWater BlueSodaWater mentioned this issue Jul 2, 2023
Merged
BlueSodaWater added a commit to BlueSodaWater/apollo that referenced this issue Jul 2, 2023
@BlueSodaWater
Fix the issue that clear content when paste the same content in names…
23244f5 
…pace (apolloconfig#4919)
nobodyiam pushed a commit to BlueSodaWater/apollo that referenced this issue Jul 2, 2023
@BlueSodaWater @nobodyiam
Fix the issue that clear content when paste the same content in names…
9703e76 
…pace (apolloconfig#4919)
nobodyiam added a commit that referenced this issue Jul 2, 2023
@BlueSodaWater @nobodyiam
Fix the issue that clear content when paste the same content in names…
c423d35 
…pace (#4922)

* Fix the issue that clear content when paste the same content in namespace (#4919)

* Update CHANGES.md

* Update apollo-portal/src/main/resources/static/scripts/directive/namespace-panel-directive.js

* Update CHANGES.md

---------

Co-authored-by: Jason Song <nobodyiam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug. help wanted
Projects
None yet
Milestone
No milestone
2 participants
@nobodyiam @BlueSodaWater