Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/ctripcorp/apollo/issues/2111 #2255

Merged
merged 1 commit into from
May 21, 2019
Merged

Conversation

bkblack
Copy link
Contributor

@bkblack bkblack commented May 20, 2019

fix #2111.

@codecov-io
Copy link

codecov-io commented May 20, 2019

Codecov Report

Merging #2255 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2255      +/-   ##
============================================
- Coverage        50%   49.93%   -0.07%     
+ Complexity     1982     1980       -2     
============================================
  Files           402      402              
  Lines         12400    12400              
  Branches       1273     1273              
============================================
- Hits           6200     6192       -8     
- Misses         5758     5765       +7     
- Partials        442      443       +1
Impacted Files Coverage Δ Complexity Δ
...igservice/controller/NotificationControllerV2.java 86.2% <100%> (ø) 31 <2> (ø) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989f37b...4fe389e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 53.508% when pulling 4fe389e on bkblack:master into 989f37b on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 469c1c1 into apolloconfig:master May 21, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 10, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotificationControllerV2的 pollNotification 与handleMessage方法是否有并发问题
4 participants