Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:ConfigChangeListener to ConfigFileChangeListener #2623

Merged
merged 3 commits into from
Oct 1, 2019
Merged

fix:ConfigChangeListener to ConfigFileChangeListener #2623

merged 3 commits into from
Oct 1, 2019

Conversation

sunshanpeng
Copy link
Contributor

declare:

private final List<ConfigFileChangeListener> m_listeners = Lists.newCopyOnWriteArrayList();

method:

@Override
  public boolean removeChangeListener(ConfigChangeListener listener) {
    return m_listeners.remove(listener);
  }

@codecov-io
Copy link

codecov-io commented Sep 29, 2019

Codecov Report

Merging #2623 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2623      +/-   ##
============================================
+ Coverage     50.05%   50.07%   +0.01%     
- Complexity     2046     2047       +1     
============================================
  Files           412      412              
  Lines         12593    12593              
  Branches       1291     1291              
============================================
+ Hits           6304     6306       +2     
+ Misses         5841     5840       -1     
+ Partials        448      447       -1
Impacted Files Coverage Δ Complexity Δ
...framework/apollo/internals/AbstractConfigFile.java 85.71% <ø> (ø) 11 <0> (ø) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 80.24% <0%> (+1.23%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fcce20...50781e6. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 29, 2019

Coverage Status

Coverage increased (+0.008%) to 53.625% when pulling 50781e6 on sunshanpeng:master into 0fcce20 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants