Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java client's long polling timeout is 90 seconds, so server side long polling timeout must be less than 90 #2630

Merged

Conversation

nobodyiam
Copy link
Member

@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bce744d). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2630   +/-   ##
=========================================
  Coverage          ?   50.07%           
  Complexity        ?     2047           
=========================================
  Files             ?      412           
  Lines             ?    12594           
  Branches          ?     1292           
=========================================
  Hits              ?     6306           
  Misses            ?     5841           
  Partials          ?      447
Impacted Files Coverage Δ Complexity Δ
...m/ctrip/framework/apollo/biz/config/BizConfig.java 31.25% <0%> (ø) 8 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce744d...a234b17. Read the comment docs.

@JaredTan95 JaredTan95 added this to the 1.5.0 milestone Oct 1, 2019
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit 35e1302 into apolloconfig:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants