Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fix i18n translations #2675

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@73cf7fe). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2675   +/-   ##
=========================================
  Coverage          ?   50.23%           
  Complexity        ?     2061           
=========================================
  Files             ?      413           
  Lines             ?    12644           
  Branches          ?     1292           
=========================================
  Hits              ?     6352           
  Misses            ?     5844           
  Partials          ?      448
Impacted Files Coverage Δ Complexity Δ
...ework/apollo/portal/controller/ItemController.java 7.31% <0%> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cf7fe...c98d157. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.78% when pulling c98d157 on nobodyiam:minor-fix-i18n into 73cf7fe on ctripcorp:master.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kezhenxu94 kezhenxu94 merged commit c9089e4 into apolloconfig:master Oct 19, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants