Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects.isNull is only available from jdk 1.8 but apollo-client is targeted to jdk 1.7+, so we need to use a compatible one #2677

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

nobodyiam
Copy link
Member

No description provided.

…rgeted to jdk 1.7+, so we need to use a compatible one
@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

Merging #2677 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2677      +/-   ##
============================================
+ Coverage     50.18%   50.21%   +0.03%     
- Complexity     2060     2061       +1     
============================================
  Files           413      413              
  Lines         12644    12644              
  Branches       1292     1292              
============================================
+ Hits           6345     6349       +4     
+ Misses         5851     5846       -5     
- Partials        448      449       +1
Impacted Files Coverage Δ Complexity Δ
...work/apollo/spring/property/PlaceholderHelper.java 80% <0%> (ø) 24 <0> (ø) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0%> (-1.18%) 24% <0%> (-1%)
...work/apollo/biz/message/DatabaseMessageSender.java 66.66% <0%> (+10.41%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7072917...9dbc39b. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 53.765% when pulling 9dbc39b on nobodyiam:fix-2646-jdk7 into 7072917 on ctripcorp:master.

@nobodyiam nobodyiam merged commit 0d824bb into apolloconfig:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants