Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.html #2726

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Update config.html #2726

merged 2 commits into from
Nov 4, 2019

Conversation

baiyun1102
Copy link
Contributor

修改应用appid显示为部门的问题

@codecov-io
Copy link

codecov-io commented Nov 4, 2019 •
edited
Loading

Codecov Report

Merging #2726 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2726      +/-   ##
===========================================
+ Coverage     50.49%   50.5%   +<.01%     
- Complexity     2082    2083       +1     
===========================================
  Files           413     413              
  Lines         12665   12665              
  Branches       1293    1293              
===========================================
+ Hits           6395    6396       +1     
  Misses         5817    5817              
+ Partials        453     452       -1
Impacted Files Coverage Δ Complexity Δ
.../apollo/internals/RemoteConfigLongPollService.java 80.24% <0%> (+0.61%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d6ef7...8fc436d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.07% when pulling 8fc436d on baiyun1102:master into f4d6ef7 on ctripcorp:master.

JaredTan95
JaredTan95 approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 added enhancement area/ui Categorizes issue or PR as related to front end labels Nov 4, 2019
@JaredTan95 JaredTan95 added this to the 1.6.0 milestone Nov 4, 2019
@JaredTan95 JaredTan95 merged commit 58d18d1 into apolloconfig:master Nov 4, 2019
@nobodyiam nobodyiam modified the milestones: 1.6.0, 1.5.1 Nov 9, 2019
@nobodyiam nobodyiam added the bug Categorizes issue or PR as related to a bug. label Nov 9, 2019
nobodyiam pushed a commit that referenced this pull request Nov 9, 2019
@baiyun1102 @nobodyiam
Update config.html (#2726)
c9eae54 
修改应用appid显示为部门的问题
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredTan95 JaredTan95 JaredTan95 approved these changes

Assignees
No one assigned
Labels
area/ui Categorizes issue or PR as related to front end bug Categorizes issue or PR as related to a bug. enhancement
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
5 participants
@baiyun1102 @codecov-io @coveralls @JaredTan95 @nobodyiam