Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关联公共配置时未发布配置表格表头乱序调整 #2914

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

wu560130911
Copy link
Contributor

@wu560130911 wu560130911 commented Jan 21, 2020

What's the purpose of this PR

关联公共配置时未发布配置表格表头乱序调整

Which issue(s) this PR fixes:

Fixes #
apollo-portal/src/main/resources/static/views/component/namespace-panel-master-tab.html
关联功能配置时,未发布配置的表头与内容乱序调整

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #2914 into master will decrease coverage by 7.94%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2914      +/-   ##
============================================
- Coverage     59.18%   51.23%   -7.95%     
- Complexity     1239     2217     +978     
============================================
  Files           203      431     +228     
  Lines          6154    13295    +7141     
  Branches        655     1365     +710     
============================================
+ Hits           3642     6812    +3170     
- Misses         2239     6007    +3768     
- Partials        273      476     +203
Impacted Files Coverage Δ Complexity Δ
.../apollo/util/factory/DefaultPropertiesFactory.java 100% <ø> (ø) 3 <0> (-1) ⬇️
...trip/framework/apollo/internals/DefaultConfig.java 82.97% <100%> (ø) 29 <0> (ø) ⬇️
...llo/configservice/controller/ConfigController.java 95.29% <100%> (ø) 26 <2> (?)
...ctrip/framework/apollo/util/OrderedProperties.java 94.28% <50%> (-2.78%) 14 <1> (ø)
...p/framework/apollo/biz/service/ReleaseService.java 73.59% <85.71%> (ø) 41 <9> (ø) ⬇️
...trip/framework/apollo/biz/service/ItemService.java 14.66% <0%> (ø) 4% <0%> (ø) ⬇️
.../portal/spi/configuration/LdapGroupProperties.java 0% <0%> (ø) 0% <0%> (?)
...ework/apollo/portal/controller/ItemController.java 7.31% <0%> (ø) 1% <0%> (?)
...o/configservice/wrapper/DeferredResultWrapper.java 100% <0%> (ø) 13% <0%> (?)
...omponent/emailbuilder/GrayPublishEmailBuilder.java 11.53% <0%> (ø) 1% <0%> (?)
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ddea95...562f867. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 62b5fb3 into apolloconfig:master Jan 21, 2020
@nobodyiam nobodyiam added this to the 1.6.0 milestone Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants