Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue that access key function doesn't work when prefix path is configured #2929

Merged

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

fix the issue that access key function doesn't work when prefix path is configured

Brief changelog

  1. change prefix path key from prefixPath to prefix.path
  2. fix the incompatible path in access key pages

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #2929 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2929   +/-   ##
=========================================
  Coverage     51.24%   51.24%           
  Complexity     2218     2218           
=========================================
  Files           431      431           
  Lines         13300    13300           
  Branches       1366     1366           
=========================================
  Hits           6815     6815           
  Misses         6009     6009           
  Partials        476      476
Impacted Files Coverage Δ Complexity Δ
...apollo/portal/controller/PrefixPathController.java 50% <ø> (ø) 1 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc33fb...c2b64ec. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.82% when pulling c2b64ec on nobodyiam:fix-prefix-path-for-access-key into ffc33fb on ctripcorp:master.

@nobodyiam nobodyiam merged commit f9b2aa6 into apolloconfig:master Feb 22, 2020
@nobodyiam nobodyiam added this to the 1.6.0 milestone Feb 22, 2020
@wu560130911
Copy link
Contributor

是否可以提供默认值?我没有做任何配置时,直接无法打开页面,毕竟大部分使用方都不是这么代理访问的
app.js:3 Uncaught ReferenceError: prefixPath is not defined
at app.js:3
(anonymous) @ app.js:3
AppUtils.js:1 Uncaught TypeError: Cannot read property 'service' of undefined
at AppUtils.js:1
(anonymous) @ AppUtils.js:1
directive.js:2 Uncaught TypeError: Cannot read property 'directive' of undefined
at directive.js:2
(anonymous) @ directive.js:2
LoginController.js:1 Uncaught TypeError: Cannot read property 'controller' of undefined
at LoginController.js:1

@nobodyiam
Copy link
Member Author

@wu560130911 默认值就是空,看下是否请求后端接口报错了

@nobodyiam nobodyiam deleted the fix-prefix-path-for-access-key branch September 26, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants