Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #3012 #3023

Merged
merged 1 commit into from
Apr 18, 2020
Merged

fix issue #3012 #3023

merged 1 commit into from
Apr 18, 2020

Conversation

nobodyiam
Copy link
Member

Which issue(s) this PR fixes:

Fixes #3012

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #3023 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3023      +/-   ##
============================================
- Coverage     51.25%   51.24%   -0.02%     
+ Complexity     2230     2229       -1     
============================================
  Files           432      432              
  Lines         13381    13382       +1     
  Branches       1374     1374              
============================================
- Hits           6859     6858       -1     
- Misses         6046     6047       +1     
- Partials        476      477       +1     
Impacted Files Coverage Δ Complexity Δ
...mework/foundation/internals/io/BOMInputStream.java 46.91% <0.00%> (-0.59%) 19.00 <0.00> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 80.12% <0.00%> (-0.61%) 28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be66448...3e86596. Read the comment docs.

@nobodyiam nobodyiam merged commit faa0921 into apolloconfig:master Apr 18, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A potential NPE bug
2 participants