Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3025 #3037

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Fix 3025 #3037

merged 2 commits into from
Apr 25, 2020

Conversation

nobodyiam
Copy link
Member

Which issue(s) this PR fixes:

Fixes #3025

Brief changelog

  1. fix potential xss issue
  2. add system administrator permission check for user manage and server config page

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #3037 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3037      +/-   ##
============================================
- Coverage     51.29%   51.25%   -0.04%     
+ Complexity     2232     2230       -2     
============================================
  Files           432      432              
  Lines         13382    13382              
  Branches       1374     1374              
============================================
- Hits           6864     6859       -5     
- Misses         6042     6047       +5     
  Partials        476      476              
Impacted Files Coverage Δ Complexity Δ
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (-10.42%) 6.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa0921...031fd6b. Read the comment docs.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 15171a6 into apolloconfig:master Apr 25, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

前端xss攻击缺陷
3 participants