Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rollback to specified release (#2858) #3093

Merged
merged 6 commits into from
Jun 14, 2020

Conversation

cbcc
Copy link
Contributor

@cbcc cbcc commented May 26, 2020

What's the purpose of this PR

  1. support rollback to the specified release version
  2. show abandoned status

Which issue(s) this PR fixes:

Fixes #2858

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #3093 into master will decrease coverage by 0.03%.
The diff coverage is 38.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3093      +/-   ##
============================================
- Coverage     51.28%   51.24%   -0.04%     
- Complexity     2233     2236       +3     
============================================
  Files           432      432              
  Lines         13385    13427      +42     
  Branches       1375     1381       +6     
============================================
+ Hits           6864     6881      +17     
- Misses         6048     6069      +21     
- Partials        473      477       +4     
Impacted Files Coverage Δ Complexity Δ
...llo/adminservice/controller/ReleaseController.java 23.72% <0.00%> (-0.84%) 3.00 <0.00> (ø)
...p/framework/apollo/portal/api/AdminServiceAPI.java 11.93% <0.00%> (-0.21%) 1.00 <0.00> (ø)
...rk/apollo/portal/controller/ReleaseController.java 10.44% <0.00%> (-1.03%) 1.00 <0.00> (ø)
...work/apollo/portal/entity/bo/ReleaseHistoryBO.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...k/apollo/portal/service/ReleaseHistoryService.java 7.46% <0.00%> (-0.12%) 1.00 <0.00> (ø)
...ramework/apollo/portal/service/ReleaseService.java 5.61% <0.00%> (-0.13%) 2.00 <0.00> (ø)
...p/framework/apollo/biz/service/ReleaseService.java 73.04% <68.00%> (-0.55%) 44.00 <3.00> (+3.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60d9dba...77f7380. Read the comment docs.

@cbcc cbcc requested a review from nobodyiam June 1, 2020 13:26
@cbcc cbcc requested a review from nobodyiam June 14, 2020 07:10
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 21f0842 into apolloconfig:master Jun 14, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

批量回滚
3 participants