Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace header misc change #3112

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jun 7, 2020

What's the purpose of this PR

  1. show item modified count in lazy init mode so that user could know which namespace to publish
  2. show namespace comment as tooltip

Which issue(s) this PR fixes:

Fixes #3082 #3118

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #3112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3112   +/-   ##
=========================================
  Coverage     51.28%   51.28%           
  Complexity     2233     2233           
=========================================
  Files           432      432           
  Lines         13385    13385           
  Branches       1375     1375           
=========================================
  Hits           6864     6864           
  Misses         6048     6048           
  Partials        473      473           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fed2f1...a260246. Read the comment docs.

@nobodyiam nobodyiam changed the title show item modified count in lazy init mode so that user could know which namespace to publish Namespace header misc change Jun 13, 2020
@nobodyiam nobodyiam linked an issue Jun 13, 2020 that may be closed by this pull request
@nobodyiam nobodyiam force-pushed the show-item-modified-count-in-lazy-init-mode branch from 461f6a9 to a260246 Compare June 14, 2020 06:56
@nobodyiam nobodyiam merged commit 60d9dba into apolloconfig:master Jun 14, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

能否在管理网页的namespace名称旁边显示备注信息? 是否可以做个一键发布?
2 participants