fix potential data inconsistency issue #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3341 +/- ##
============================================
- Coverage 51.46% 51.43% -0.04%
- Complexity 2302 2303 +1
============================================
Files 442 442
Lines 13738 13741 +3
Branches 1398 1399 +1
============================================
- Hits 7070 7067 -3
- Misses 6181 6188 +7
+ Partials 487 486 -1
Continue to review full report at Codecov.
|
nobodyiam
force-pushed
the
fix-potential-data-inconsistency-issue
branch
from
71dab1f
to
16dafc5
Compare
Closed
huayaoyue6
reviewed
Jan 13, 2022
| @@ -113,7 +113,7 @@ public void deleteItem(@PathVariable String appId, @PathVariable String env, | |||
| NamespaceDTO namespace = namespaceService.loadNamespaceBaseInfo(appId, Env.valueOf(env), clusterName, namespaceName); | |||
|
|
|||
| // In case someone constructs an attack scenario | |||
| if (item.getNamespaceId() != namespace.getId()) { | |||
| if (namespace == null || item.getNamespaceId() != namespace.getId()) { | |||
There was a problem hiding this comment.
此处的namespace为空的判断是非必要的，因为在113行的loadNamespaceBaseInfo中的逻辑里已经对null做出了抛异常的处理。
There was a problem hiding this comment.
you are right, but I assume it has no harm so we could leave it as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
fix potential data inconsistency issue
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.