Added nacos service discovery support #3447

klboke · 2020-12-19T10:41:20Z

新增nacos服务发现支持，使用方法如下：
启用外部的nacos服务注册中心分两步走，configService和adminService的操作一样，如下：

1、修改VM options，激活nacosDiscovery的profile，如：

-Dapollo_profile=github,auth,nacosDiscovery

2、前往application-github.properties配置nacos连接地址，如：

#nacos discovery
nacos.discovery.server-addr=127.0.0.1:8848

也可采用VM options的方式配置，如：

-Dnacos.discovery.server-addr=127.0.0.1:8848

# Conflicts: # README.md

klboke · 2020-12-19T10:46:29Z

#3444

apollo-adminservice/pom.xml

apollo-configservice/pom.xml

...vice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/HomePageController.java

...rvice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/ServiceController.java

apollo-adminservice/src/main/resources/application-nacosDiscovery.properties

...vice/src/main/java/com/ctrip/framework/apollo/metaservice/service/NacosDiscoveryService.java

docs/zh/deployment/distributed-deployment-guide.md

...vice/src/main/java/com/ctrip/framework/apollo/metaservice/service/NacosDiscoveryService.java

nobodyiam · 2020-12-21T13:15:57Z

I checked out this branch, start the application but failed...
It looks like the nacos.discovery.enabled is default to true, which activates nacos discovery by default...

java.io.IOException: Error while requesting: http:///nacos/serverlist'. Server returned: 500
	at com.alibaba.nacos.client.naming.net.NamingProxy.getServerListFromEndpoint(NamingProxy.java:142)
	at com.alibaba.nacos.client.naming.net.NamingProxy.refreshSrvIfNeed(NamingProxy.java:175)
	at com.alibaba.nacos.client.naming.net.NamingProxy.access$000(NamingProxy.java:60)
	at com.alibaba.nacos.client.naming.net.NamingProxy$2.run(NamingProxy.java:118)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
java.io.IOException: Error while requesting: http:///nacos/serverlist'. Server returned: 500
	at com.alibaba.nacos.client.naming.net.NamingProxy.getServerListFromEndpoint(NamingProxy.java:142)
	at com.alibaba.nacos.client.naming.net.NamingProxy.refreshSrvIfNeed(NamingProxy.java:175)
	at com.alibaba.nacos.client.naming.net.NamingProxy.initRefreshTask(NamingProxy.java:130)
	at com.alibaba.nacos.client.naming.net.NamingProxy.<init>(NamingProxy.java:100)
	at com.alibaba.nacos.client.naming.NacosNamingService.init(NacosNamingService.java:96)
	at com.alibaba.nacos.client.naming.NacosNamingService.<init>(NacosNamingService.java:85)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at com.alibaba.nacos.api.naming.NamingFactory.createNamingService(NamingFactory.java:45)
	at com.alibaba.nacos.api.NacosFactory.createNamingService(NacosFactory.java:76)

Then I configured nacos.discovery.enabled=false, but it still failed to start. It looks to me the spring property sources are somehow wrong after nacos dependency is added.

Caused by: java.sql.SQLSyntaxErrorException: Table 'apolloconfigdb.server_config' doesn't exist
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:120)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:955)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeQuery(ClientPreparedStatement.java:1005)
	at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeQuery(ProxyPreparedStatement.java:52)
	at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeQuery(HikariProxyPreparedStatement.java)
	at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.extract(ResultSetReturnImpl.java:60)
	... 121 common frames omitted

klboke · 2020-12-21T14:14:43Z

I checked out this branch, start the application but failed...
It looks like the nacos.discovery.enabled is default to true, which activates nacos discovery by default...

java.io.IOException: Error while requesting: http:///nacos/serverlist'. Server returned: 500
	at com.alibaba.nacos.client.naming.net.NamingProxy.getServerListFromEndpoint(NamingProxy.java:142)
	at com.alibaba.nacos.client.naming.net.NamingProxy.refreshSrvIfNeed(NamingProxy.java:175)
	at com.alibaba.nacos.client.naming.net.NamingProxy.access$000(NamingProxy.java:60)
	at com.alibaba.nacos.client.naming.net.NamingProxy$2.run(NamingProxy.java:118)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
java.io.IOException: Error while requesting: http:///nacos/serverlist'. Server returned: 500
	at com.alibaba.nacos.client.naming.net.NamingProxy.getServerListFromEndpoint(NamingProxy.java:142)
	at com.alibaba.nacos.client.naming.net.NamingProxy.refreshSrvIfNeed(NamingProxy.java:175)
	at com.alibaba.nacos.client.naming.net.NamingProxy.initRefreshTask(NamingProxy.java:130)
	at com.alibaba.nacos.client.naming.net.NamingProxy.<init>(NamingProxy.java:100)
	at com.alibaba.nacos.client.naming.NacosNamingService.init(NacosNamingService.java:96)
	at com.alibaba.nacos.client.naming.NacosNamingService.<init>(NacosNamingService.java:85)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at com.alibaba.nacos.api.naming.NamingFactory.createNamingService(NamingFactory.java:45)
	at com.alibaba.nacos.api.NacosFactory.createNamingService(NacosFactory.java:76)

Then I configured nacos.discovery.enabled=false, but it still failed to start. It looks to me the spring property sources are somehow wrong after nacos dependency is added.

Caused by: java.sql.SQLSyntaxErrorException: Table 'apolloconfigdb.server_config' doesn't exist
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:120)
	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:122)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeInternal(ClientPreparedStatement.java:955)
	at com.mysql.cj.jdbc.ClientPreparedStatement.executeQuery(ClientPreparedStatement.java:1005)
	at com.zaxxer.hikari.pool.ProxyPreparedStatement.executeQuery(ProxyPreparedStatement.java:52)
	at com.zaxxer.hikari.pool.HikariProxyPreparedStatement.executeQuery(HikariProxyPreparedStatement.java)
	at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.extract(ResultSetReturnImpl.java:60)
	... 121 common frames omitted

I overlooked that nacos is turned on by default, but you can start the project after disabling it. nacos-discovery-spring-boot-starter only includes spring integration of service discovery part, it has nothing to do with config. If you still cannot get up after disabling it, is this an environmental issue?

codecov-io · 2020-12-21T14:14:51Z

Codecov Report

Merging #3447 (da6b767) into master (ad63e14) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #3447      +/-   ##
============================================
- Coverage     51.41%   51.39%   -0.03%     
- Complexity     2316     2318       +2     
============================================
  Files           441      442       +1     
  Lines         13823    13843      +20     
  Branches       1408     1408              
============================================
+ Hits           7107     7114       +7     
- Misses         6226     6237      +11     
- Partials        490      492       +2

Impacted Files	Coverage Δ	Complexity Δ
...o/metaservice/service/DefaultDiscoveryService.java	`100.00% <ø> (ø)`	`6.00 <0.00> (ø)`
...llo/metaservice/service/NacosDiscoveryService.java	`85.00% <85.00%> (ø)`	`6.00 <6.00> (?)`
...llo/metaservice/controller/HomePageController.java	`100.00% <100.00%> (ø)`	`2.00 <1.00> (?)`
...work/apollo/biz/message/DatabaseMessageSender.java	`56.25% <0.00%> (-8.34%)`	`6.00% <0.00%> (-2.00%)`
...rk/apollo/spring/property/SpringValueRegistry.java	`83.33% <0.00%> (-5.56%)`	`10.00% <0.00%> (-1.00%)`
...ework/apollo/internals/RemoteConfigRepository.java	`86.25% <0.00%> (-3.13%)`	`24.00% <0.00%> (-1.00%)`
.../framework/apollo/spring/property/SpringValue.java	`87.71% <0.00%> (-1.76%)`	`20.00% <0.00%> (-1.00%)`
.../apollo/internals/RemoteConfigLongPollService.java	`78.31% <0.00%> (+1.20%)`	`29.00% <0.00%> (+1.00%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843cd94...da6b767. Read the comment docs.

nobodyiam · 2020-12-26T12:22:51Z

@klboke

ApolloApplication starts with the above errors...

I did some debugging and found nacos-client has an application.properties which overrides apollo-common/src/main/resources/application.properties

apollo-adminservice/src/main/config/application-github.properties

klboke · 2020-12-26T12:30:06Z

It turns out that the problem is here. I have always used separate ConfigService and AdminService to start services, so we see different phenomena. I will continue to see the solution

nobodyiam · 2020-12-26T12:39:33Z

After I activated the nacosDiscovery profile, I got this error...

java.lang.NullPointerException: null
	at com.ctrip.framework.apollo.metaservice.service.NacosDiscoveryService.getServiceInstances(NacosDiscoveryService.java:37)
	at com.ctrip.framework.apollo.metaservice.controller.ServiceController.getConfigService(ServiceController.java:35)

klboke · 2020-12-26T12:47:26Z

@nobodyiam The reason for the problem is because you are running in ApolloApplication, I have not tested it in this mode

klboke · 2020-12-29T16:11:13Z

@nobodyiam 通过maven的profile隔离了nacos-discovery-spring-boot-starter的依赖，默认只有nacos-api的依赖解决编译问题，nacos-api.1.4.0版本已经将application.properties文件挪走了，不影响ApolloApplication的启动。但是nacosDis'covery的spring-profile有缺陷，不支持ApolloApplication模式启动，原因是未配置@componentscan扫描，ApolloApplication模式下没法启用自动配置。验证时只能通过ConfigServiceApplication和AdminServiceApplication单独启动。
nacos只作为备选注册服务发现方案
The dependency of nacos-discovery-spring-boot-starter is isolated through the maven profile. By default, only the dependency of nacos-api solves the compilation problem. The nacos-api.1.4.0 version has moved the application.properties file and does not affect ApolloApplication Start. However, the spring-profile of nacosDis'covery is defective and does not support ApolloApplication mode startup. The reason is that @componentscan scanning is not configured, and automatic configuration cannot be enabled in ApolloApplication mode. The verification can only be started separately through ConfigServiceApplication and AdminServiceApplication. nacos is only an alternative registration service discovery solution

nobodyiam

It works by using maven profile, with the following suggestions.

apollo-adminservice/src/main/resources/application-nacosDiscovery.properties

apollo-biz/pom.xml

...vice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/HomePageController.java

...rvice/src/main/java/com/ctrip/framework/apollo/metaservice/controller/ServiceController.java

...ce/src/main/java/com/ctrip/framework/apollo/metaservice/service/DefaultDiscoveryService.java

...vice/src/main/java/com/ctrip/framework/apollo/metaservice/service/NacosDiscoveryService.java

docs/zh/deployment/distributed-deployment-guide.md

nobodyiam

LGTM

klboke and others added 11 commits May 16, 2019 11:07

add tech-support-qq-4.png

fe75b4d

Update README.md

99bf97a

Merge remote-tracking branch 'upstream/master'

1579f41

# Conflicts: # README.md

Merge remote-tracking branch 'upstream/master'

9f65eed

Enhance the user experience in the scenario of submitting duplicate keys

d7d3fd9

Merge branch 'master' into master

7329fab

Modify the key-value conflict exception prompt, adjust the code style

5def448

Merge branch 'master' into master

6942564

Merge remote-tracking branch 'upstream/master'

0fc1f91

Merge remote-tracking branch 'origin/master'

61ad016

Added nacos service discovery support

e12a480

nobodyiam requested changes Dec 20, 2020

View reviewed changes

klboke added 3 commits December 21, 2020 17:16

add NacosDiscoveryServiceTest.java

da1b764

use logger print Nacosxception

02b65cb

Fix UnnecessaryStubbingException thrown by NacosDiscoveryServiceTest

6ecfbe6

Nacosdiscovery is disabled by default

03f6e35

Anilople added feature Categorizes issue as related to a new feature. area/metaserver apollo meta server labels Dec 22, 2020

nobodyiam reviewed Dec 26, 2020

View reviewed changes

apollo-adminservice/src/main/config/application-github.properties Outdated Show resolved Hide resolved

Isolate nacos service discovery dependencies through maven profile

bdc9a5b

nobodyiam requested changes Jan 2, 2021

View reviewed changes

Modify the nacos service discovery activation naming style

1cfe1e0

nobodyiam requested changes Jan 2, 2021

View reviewed changes

klboke and others added 5 commits January 2, 2021 23:24

Modify nacos service discovery usage document

3262be4

Update distributed-deployment-guide.md

1a87aea

Update HomePageController.java

0e308df

Update DefaultDiscoveryService.java

fa710d2

Update distributed-deployment-guide.md

4af2656

nobodyiam approved these changes Jan 3, 2021

View reviewed changes

Merge branch 'master' into nacos

da6b767

nobodyiam merged commit 41519f4 into apolloconfig:master Jan 3, 2021

nobodyiam added this to the 1.8.0 milestone Feb 11, 2021

This was referenced Feb 19, 2021

Support register to Consul #3556

Closed

Support register to Zookeeper #3557

Closed

PostgreSQL1989 mentioned this pull request May 18, 2021

请问apollo v1.8.1如何使用nacos注册中心？ #3690

Closed

3 tasks

klboke deleted the nacos branch May 19, 2021 08:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added nacos service discovery support #3447

Added nacos service discovery support #3447

klboke commented Dec 19, 2020

klboke commented Dec 19, 2020

nobodyiam commented Dec 21, 2020 •

edited

Loading

klboke commented Dec 21, 2020

codecov-io commented Dec 21, 2020 •

edited

Loading

nobodyiam commented Dec 26, 2020

klboke commented Dec 26, 2020

nobodyiam commented Dec 26, 2020 •

edited

Loading

klboke commented Dec 26, 2020

klboke commented Dec 29, 2020

nobodyiam left a comment

nobodyiam left a comment

Added nacos service discovery support #3447

Added nacos service discovery support #3447

Conversation

klboke commented Dec 19, 2020

klboke commented Dec 19, 2020

nobodyiam commented Dec 21, 2020 • edited Loading

klboke commented Dec 21, 2020

codecov-io commented Dec 21, 2020 • edited Loading

Codecov Report

nobodyiam commented Dec 26, 2020

klboke commented Dec 26, 2020

nobodyiam commented Dec 26, 2020 • edited Loading

klboke commented Dec 26, 2020

klboke commented Dec 29, 2020

nobodyiam left a comment

Choose a reason for hiding this comment

nobodyiam left a comment

Choose a reason for hiding this comment

nobodyiam commented Dec 21, 2020 •

edited

Loading

codecov-io commented Dec 21, 2020 •

edited

Loading

nobodyiam commented Dec 26, 2020 •

edited

Loading