extend DataChange_CreatedBy, DataChange_LastModifiedBy from 32 to 64 #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3552 +/- ##
============================================
+ Coverage 50.93% 50.94% +0.01%
- Complexity 2323 2324 +1
============================================
Files 447 447
Lines 13989 13989
Branches 1423 1423
============================================
+ Hits 7125 7127 +2
+ Misses 6375 6374 -1
+ Partials 489 488 -1
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Feb 19, 2021
| @@ -7,3 +7,55 @@ alter table `GrayReleaseRule` change AppId AppId varchar(64) NOT NULL DEFAULT ' | |||
| alter table `Instance` change AppId AppId varchar(64) NOT NULL DEFAULT 'default' COMMENT 'app id'; | |||
| alter table `InstanceConfig` change ConfigAppId ConfigAppId varchar(64) NOT NULL DEFAULT 'default' COMMENT 'Config App Id'; | |||
| alter table `ReleaseHistory` change AppId AppId varchar(64) NOT NULL DEFAULT 'default' COMMENT 'app id'; | |||
|
|
|||
| ALTER TABLE `App` | |||
There was a problem hiding this comment.
as apollo 1.8.0 was released, please put it into another folder as v180-v190
nobodyiam
reviewed
Feb 19, 2021
| @@ -3,3 +3,47 @@ | |||
| Use ApolloPortalDB; | |||
|
|
|||
| alter table `AppNamespace` change AppId AppId varchar(64) NOT NULL DEFAULT 'default' COMMENT 'app id'; | |||
|
|
|||
| ALTER TABLE `App` | |||
There was a problem hiding this comment.
as apollo 1.8.0 was released, please put it into another folder as v180-v190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend DataChange_CreatedBy, DataChange_LastModifiedBy from 32 to 64
DataChange_CreatedBy,DataChange_LastModifiedByequals toApolloPortalDB.Users.Username