Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable consul in apollo-assembly by default #3585

Merged
merged 1 commit into from
Mar 6, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

disable consul in apollo-assembly by default

Which issue(s) this PR fixes:

Fixes #3581

Brief changelog

disable consul in apollo-assembly by default

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@nobodyiam
Copy link
Member Author

#3575

@codecov-io
Copy link

Codecov Report

Merging #3585 (09fbb5b) into master (d2059e6) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3585      +/-   ##
============================================
+ Coverage     50.95%   50.99%   +0.04%     
- Complexity     2324     2328       +4     
============================================
  Files           447      448       +1     
  Lines         13989    14006      +17     
  Branches       1423     1424       +1     
============================================
+ Hits           7128     7143      +15     
- Misses         6373     6374       +1     
- Partials        488      489       +1     
Impacted Files Coverage Δ Complexity Δ
...llo/metaservice/controller/HomePageController.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...o/metaservice/service/DefaultDiscoveryService.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...lo/metaservice/service/ConsulDiscoveryService.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) 28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06813f...09fbb5b. Read the comment docs.

@nobodyiam nobodyiam merged commit f192c77 into apolloconfig:master Mar 6, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

启动portalapplication 报错
2 participants