-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace http client implementation with interface #3594
Conversation
@@ -19,14 +19,14 @@ | |||
/** | |||
* @author Jason Song(song_s@ctrip.com) | |||
*/ | |||
public class HttpUtil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may still keep the class HttpUtil
and delegate its implementation to the HttpClient
because some application might already reference it. I did a quick search in github, and found the possibility is true.
To avoid future misuse, we could mark it as @Deprecated
.
Codecov Report
@@ Coverage Diff @@
## master #3594 +/- ##
============================================
- Coverage 51.00% 50.78% -0.22%
Complexity 2328 2328
============================================
Files 448 449 +1
Lines 14006 14066 +60
Branches 1424 1434 +10
============================================
Hits 7144 7144
- Misses 6373 6433 +60
Partials 489 489
Continue to review full report at Codecov.
|
make it easier to customize http client