Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace http client implementation with interface #3594

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Mar 10, 2021

make it easier to customize http client

@@ -19,14 +19,14 @@
/**
* @author Jason Song(song_s@ctrip.com)
*/
public class HttpUtil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may still keep the class HttpUtil and delegate its implementation to the HttpClient because some application might already reference it. I did a quick search in github, and found the possibility is true.

To avoid future misuse, we could mark it as @Deprecated.

@codecov-io
Copy link

Codecov Report

Merging #3594 (7420982) into master (f192c77) will decrease coverage by 0.21%.
The diff coverage is 77.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3594      +/-   ##
============================================
- Coverage     51.00%   50.78%   -0.22%     
  Complexity     2328     2328              
============================================
  Files           448      449       +1     
  Lines         14006    14066      +60     
  Branches       1424     1434      +10     
============================================
  Hits           7144     7144              
- Misses         6373     6433      +60     
  Partials        489      489              
Impacted Files Coverage Δ Complexity Δ
...com/ctrip/framework/apollo/util/http/HttpUtil.java 0.00% <ø> (-75.00%) 0.00 <0.00> (-9.00)
.../framework/apollo/util/http/DefaultHttpClient.java 75.00% <75.00%> (ø) 9.00 <9.00> (?)
...amework/apollo/internals/ConfigServiceLocator.java 89.58% <100.00%> (ø) 20.00 <0.00> (ø)
...ip/framework/apollo/internals/DefaultInjector.java 68.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <100.00%> (-0.61%) 28.00 <0.00> (-1.00)
...ework/apollo/internals/RemoteConfigRepository.java 89.37% <100.00%> (ø) 25.00 <0.00> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) 24.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de34fe5...7420982. Read the comment docs.

@nobodyiam nobodyiam merged commit 9f3d315 into apolloconfig:master Mar 16, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Mar 16, 2021
@vdiskg vdiskg deleted the http-client branch June 27, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants