Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test #3669

Merged
merged 2 commits into from
May 9, 2021
Merged

fix unit test #3669

merged 2 commits into from
May 9, 2021

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented May 9, 2021

newSingleThreadExecutor has a bug, and it only fixed on jdk11. while running on jdk8, it may break the unit test by accident (depend on gc)
https://bugs.openjdk.java.net/browse/JDK-8145304

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #3669 (821308e) into master (20b8ddb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3669   +/-   ##
=========================================
  Coverage     50.98%   50.98%           
+ Complexity     2331     2330    -1     
=========================================
  Files           449      449           
  Lines         14026    14026           
  Branches       1426     1426           
=========================================
  Hits           7151     7151           
+ Misses         6390     6389    -1     
- Partials        485      486    +1     
Impacted Files Coverage Δ Complexity Δ
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) 28.00% <0.00%> (-1.00%)
...lo/configservice/util/InstanceConfigAuditUtil.java 76.06% <0.00%> (+1.70%) 15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b8ddb...821308e. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 765f3b8 into apolloconfig:master May 9, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
@vdiskg vdiskg deleted the fix-unit-test branch June 27, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants