Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default session store-type #3812

Merged
merged 3 commits into from
Jul 9, 2021
Merged

set default session store-type #3812

merged 3 commits into from
Jul 9, 2021

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Jul 6, 2021

What's the purpose of this PR

fix fail start

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lonre
Copy link
Contributor Author

lonre commented Jul 6, 2021

I have read the CLA Document and I hereby sign the CLA

@nobodyiam nobodyiam requested a review from vdiskg July 7, 2021 00:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #3812 (b81c5de) into master (ab6a172) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3812      +/-   ##
============================================
- Coverage     50.14%   50.07%   -0.08%     
+ Complexity     2444     2443       -1     
============================================
  Files           479      479              
  Lines         14807    14807              
  Branches       1503     1503              
============================================
- Hits           7425     7414      -11     
- Misses         6859     6871      +12     
+ Partials        523      522       -1     
Impacted Files Coverage Δ
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 57.81% <0.00%> (-7.82%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6a172...b81c5de. Read the comment docs.

vdiskg
vdiskg previously approved these changes Jul 7, 2021
Copy link
Contributor

@vdiskg vdiskg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdiskg
Copy link
Contributor

vdiskg commented Jul 7, 2021

please update the CHANGES.md

@vdiskg vdiskg self-requested a review July 7, 2021 03:45
vdiskg
vdiskg previously approved these changes Jul 7, 2021
@vdiskg vdiskg merged commit 907dbad into apolloconfig:master Jul 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Jul 11, 2021
@lonre lonre deleted the patch-1 branch April 11, 2022 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants