-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce bootstrap time in the situation with large properties #3816
Reduce bootstrap time in the situation with large properties #3816
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
389f967
to
04898e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3816 +/- ##
============================================
+ Coverage 49.93% 50.10% +0.16%
- Complexity 2442 2460 +18
============================================
Files 482 483 +1
Lines 14853 14891 +38
Branches 1507 1515 +8
============================================
+ Hits 7417 7461 +44
+ Misses 6914 6906 -8
- Partials 522 524 +2
Continue to review full report at Codecov.
|
04898e9
to
2e89f18
Compare
apollo-client/src/main/java/com/ctrip/framework/apollo/Config.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ctrip/framework/apollo/spring/boot/ApolloApplicationContextInitializer.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/spring/config/ConfigPropertySource.java
Outdated
Show resolved
Hide resolved
796d55f
to
542951e
Compare
...nt/src/main/java/com/ctrip/framework/apollo/spring/config/CompositeConfigPropertySource.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/config/CompositeConfigPropertySource.java
Outdated
Show resolved
Hide resolved
f262156
to
b37687c
Compare
b37687c
to
9979023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically it looks good now except for some minor comments, thanks!
...rc/main/java/com/ctrip/framework/apollo/spring/boot/ApolloApplicationContextInitializer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ctrip/framework/apollo/spring/boot/ApolloApplicationContextInitializer.java
Show resolved
Hide resolved
...-client/src/main/java/com/ctrip/framework/apollo/spring/config/PropertySourcesProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/config/CompositeConfigPropertySource.java
Outdated
Show resolved
Hide resolved
Please also update the branch and solve the conflicts in |
...nt/src/main/java/com/ctrip/framework/apollo/spring/config/CompositeConfigPropertySource.java
Outdated
Show resolved
Hide resolved
9979023
to
c8e839d
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
Reduce bootstrap time in the situation with large properties.
Use test method described in #3800, compare results:
Which issue(s) this PR fixes:
Fixes #3800
Brief changelog
Reduce bootstrap time in the situation with large properties.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.