Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support release apollo-client-config-data #3822

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Jul 12, 2021

What's the purpose of this PR

support release apollo-client-config-data

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@72a0498). Click here to learn what that means.
The diff coverage is 55.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3822   +/-   ##
=========================================
  Coverage          ?   49.98%           
  Complexity        ?     2444           
=========================================
  Files             ?      482           
  Lines             ?    14853           
  Branches          ?     1507           
=========================================
  Hits              ?     7425           
  Misses            ?     6905           
  Partials          ?      523           
Impacted Files Coverage Δ
...k/apollo/adminservice/AdminServiceApplication.java 0.00% <ø> (ø)
...mework/apollo/adminservice/ServletInitializer.java 0.00% <ø> (ø)
...o/adminservice/aop/NamespaceAcquireLockAspect.java 70.17% <ø> (ø)
.../apollo/adminservice/controller/AppController.java 86.20% <ø> (ø)
...dminservice/controller/AppNamespaceController.java 34.61% <ø> (ø)
...llo/adminservice/controller/ClusterController.java 56.00% <ø> (ø)
...ollo/adminservice/controller/CommitController.java 60.00% <ø> (ø)
...pollo/adminservice/controller/IndexController.java 50.00% <ø> (ø)
...inservice/controller/InstanceConfigController.java 92.77% <ø> (ø)
...llo/adminservice/controller/ItemSetController.java 100.00% <ø> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a0498...049061e. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 622e35a into apolloconfig:master Jul 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
@lonre lonre deleted the patch-2 branch April 11, 2022 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants