Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: public namespace support different formats #3836

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

dake0805
Copy link
Contributor

@dake0805 dake0805 commented Jul 20, 2021

What's the purpose of this PR

Add new feature:

  • Can create public namespace in different formats, include json, xml, yml, yaml, txt, just like creating a private namespace.
  • Public namespace in these formats can be associated correctly.

Discussion

Which issue(s) this PR fixes:

Fixes #2602

Brief changelog

  • Remove verify formats of creating public namespace in portal API and front-end
  • Add front-end elements to create public namespace in formats
  • Add front-end text box to show associated namespace when parent namespace are different with child namespace.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

dake0805 and others added 4 commits July 17, 2021 23:06
- change front-end and portal service to allow create new namespace in format json/yaml/xml/txt

- can not associating namespace of these formats now

- todo: change some documents on front-end page
@dake0805 dake0805 changed the title feature: public namespace support many formats: json feature: public namespace support different formats Jul 20, 2021
@nobodyiam nobodyiam requested a review from lepdou July 22, 2021 00:14
@lepdou lepdou merged commit 109c98d into apolloconfig:master Aug 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

请考虑支持应用的默认命名空间和公共命名空间为其他可选的配置格式
4 participants