Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summer2021 support more format #3871

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Aug 5, 2021

What's the purpose of this PR

  1. remove useless code
  2. add change log
  3. fix failed ut

Which issue(s) this PR fixes:

#3815

Brief changelog

remove useless code and add change log

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@lepdou lepdou force-pushed the summer2021_support_more_format branch from 3e53359 to e19b9de Compare August 5, 2021 10:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #3871 (41019b6) into master (7afe23b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3871      +/-   ##
============================================
+ Coverage     50.11%   50.14%   +0.03%     
  Complexity     2464     2464              
============================================
  Files           483      483              
  Lines         14921    14919       -2     
  Branches       1520     1519       -1     
============================================
+ Hits           7477     7481       +4     
+ Misses         6914     6910       -4     
+ Partials        530      528       -2     
Impacted Files Coverage Δ
...ork/apollo/portal/service/AppNamespaceService.java 75.00% <ø> (-0.56%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+0.60%) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 109c98d...41019b6. Read the comment docs.

@lepdou lepdou force-pushed the summer2021_support_more_format branch from e19b9de to 31518b6 Compare August 5, 2021 12:00
@lepdou
Copy link
Contributor Author

lepdou commented Aug 5, 2021

recheck

1 similar comment
@lepdou
Copy link
Contributor Author

lepdou commented Aug 5, 2021

recheck

2. fix failed ut
3. add change log
@lepdou lepdou force-pushed the summer2021_support_more_format branch from 629119e to 41019b6 Compare August 5, 2021 12:34
@lepdou lepdou merged commit 2781147 into apolloconfig:master Aug 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants