Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish log #3882

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Polish log #3882

merged 1 commit into from
Aug 11, 2021

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Aug 10, 2021

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #3882 (75ff290) into master (2c9b4dc) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3882   +/-   ##
=========================================
  Coverage     50.13%   50.14%           
- Complexity     2477     2478    +1     
=========================================
  Files           485      485           
  Lines         14983    14984    +1     
  Branches       1532     1532           
=========================================
+ Hits           7511     7513    +2     
+ Misses         6939     6938    -1     
  Partials        533      533           
Impacted Files Coverage Δ
...ip/framework/apollo/mockserver/EmbeddedApollo.java 92.77% <0.00%> (ø)
...rk/apollo/spring/property/SpringValueRegistry.java 83.78% <50.00%> (+0.45%) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9b4dc...75ff290. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2e2919d into apolloconfig:master Aug 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2021
@lonre lonre deleted the f branch April 11, 2022 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants