Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ctrip profile #3920

Merged
merged 9 commits into from
Aug 29, 2021
Merged

Conversation

JaredTan95
Copy link
Member

What's the purpose of this PR

remove ctrip profile and update org info.

@JaredTan95 JaredTan95 requested review from kezhenxu94, nobodyiam and klboke and removed request for kezhenxu94 and nobodyiam August 26, 2021 03:54
@JaredTan95 JaredTan95 added the area/portal apollo-portal label Aug 26, 2021
@JaredTan95 JaredTan95 added this to the 1.10.0 milestone Aug 26, 2021
@JaredTan95 JaredTan95 linked an issue Aug 26, 2021 that may be closed by this pull request
2 tasks
kezhenxu94
kezhenxu94 previously approved these changes Aug 26, 2021
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like code style is different which introduces a lot of unnecessary changes, please use the apollo code style to format the code, thanks!

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 9f072d8 into apolloconfig:master Aug 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
@JaredTan95 JaredTan95 deleted the remove_ctrip_profile branch August 29, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/portal apollo-portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apollo organization related content needs to be updated
3 participants