-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove ctrip profile #3920
Merged
nobodyiam
merged 9 commits into
apolloconfig:master
from
JaredTan95:remove_ctrip_profile
Aug 29, 2021
Merged
remove ctrip profile #3920
nobodyiam
merged 9 commits into
apolloconfig:master
from
JaredTan95:remove_ctrip_profile
Aug 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredTan95
requested review from
kezhenxu94,
nobodyiam and
klboke
and removed request for
kezhenxu94 and
nobodyiam
August 26, 2021 03:54
2 tasks
kezhenxu94
previously approved these changes
Aug 26, 2021
nobodyiam
requested changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like code style is different which introduces a lot of unnecessary changes, please use the apollo code style to format the code, thanks!
nobodyiam
approved these changes
Aug 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
remove ctrip profile and update org info.
CHANGES
log.