Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to 2.0.0 and drop java 1.7 support #4015

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

bump to 2.0.0 and drop java 1.7 support

Which issue(s) this PR fixes:

see discussion #3896

Brief changelog

  • update version to 2.0.0
  • remove java.version override of apollo-client and apollo-core
  • remove github action for java 1.7

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #4015 (a583aa6) into master (67a78ef) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4015      +/-   ##
============================================
- Coverage     51.54%   51.49%   -0.06%     
+ Complexity     2533     2530       -3     
============================================
  Files           484      484              
  Lines         14839    14839              
  Branches       1537     1537              
============================================
- Hits           7649     7641       -8     
- Misses         6658     6666       +8     
  Partials        532      532              
Impacted Files Coverage Δ
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a78ef...a583aa6. Read the comment docs.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property <java.version>1.7</java.version> In module apollo-demo and apollo-mockserver should also delete?

<java.version>1.7</java.version>

<java.version>1.7</java.version>

@nobodyiam
Copy link
Member Author

@Anilople Thanks for the reminder, I missed these places.

Anilople
Anilople previously approved these changes Oct 7, 2021
@nobodyiam nobodyiam merged commit 85d6b87 into apolloconfig:master Oct 9, 2021
@nobodyiam nobodyiam deleted the bump-2-0-0 branch October 9, 2021 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants