Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize navbar style #4073

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Oct 31, 2021

  1. optimize logo's size
  2. change search input's with from 350px to 375px
  3. add switch language icon

before

image

after

image

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

2. change search input's with from 350px to 375px
3. add switch language icon
@lepdou lepdou force-pushed the dev/lepdou/2.0.0_optimize_nav branch from 2c56deb to 53cbc6e Compare October 31, 2021 10:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #4073 (53cbc6e) into master (02a4df5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4073   +/-   ##
=========================================
  Coverage     51.69%   51.69%           
- Complexity     2548     2549    +1     
=========================================
  Files           484      484           
  Lines         14844    14844           
  Branches       1536     1536           
=========================================
+ Hits           7673     7674    +1     
  Misses         6637     6637           
+ Partials        534      533    -1     
Impacted Files Coverage Δ
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a4df5...53cbc6e. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@nobodyiam nobodyiam merged commit d0c7dc9 into apolloconfig:master Oct 31, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
@nobodyiam nobodyiam added this to the 2.0.0 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants