Fix flaky test testGetPropertyNames. #4082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the flaky test testGetPropertyNames due to the non-deterministic iteration order of HashSet.
This flaky test is found by using Nondex, a tool used to find flaky tests in Java projects. The original assertion on Line#69 may fail because the iteration order of HashSet is non-deterministic, and the elements in the array converted from
somePropertyNames
may not be the same as the arrayresult
. By convertingresult
to a HashSet, the new assertionassertEquals
will only check the elements are equal in both sets so that the test will always pass.