Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4152 #4161

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Fix #4152 #4161

merged 2 commits into from
Dec 19, 2021

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Dec 17, 2021

beanFactory.isTypeMatch may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.

related to #2328 #3865

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam added this to the 1.9.2 milestone Dec 18, 2021
@nobodyiam
Copy link
Member

nobodyiam commented Dec 18, 2021

Thanks for the quick fix, would you please also rebase your local 1.x branch and update the CHANGES.md?

`beanFactory.isTypeMatch` may lead to the initialization of FactoryBean,
dubbo consumer is a ReferenceBean which implements FactoryBean.

related to apolloconfig#2328 apolloconfig#3865
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 83e87ba into apolloconfig:1.x Dec 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
@nobodyiam
Copy link
Member

@lonre I just found a problem that the getFactoryMethodMetadata used is only available from spring 4.1.1+, which is a breaking change as apollo shall support spring 3.1.1+

	/**
	 * Obtain metadata for this bean definition's factory method, if any.
	 * @return the factory method metadata, or {@code null} if none
	 * @since 4.1.1
	 */
	@Nullable
	MethodMetadata getFactoryMethodMetadata();

@lonre lonre deleted the 1.x branch December 20, 2021 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants