feature: isCommonlyUsed password check not hardcoded #4018 #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillardHu
force-pushed
the
feat/issue-4018
branch
from
dc6c986
to
fcd0674
Compare
Codecov Report
@@ Coverage Diff @@
## master #4207 +/- ##
============================================
- Coverage 52.59% 52.54% -0.05%
+ Complexity 2620 2619 -1
============================================
Files 484 484
Lines 15192 15201 +9
Branches 1571 1573 +2
============================================
- Hits 7990 7988 -2
- Misses 6645 6654 +9
- Partials 557 559 +2
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Jan 14, 2022
...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java
Outdated
Show resolved
Hide resolved
...al/src/main/java/com/ctrip/framework/apollo/portal/util/checker/AuthUserPasswordChecker.java
Outdated
Show resolved
Hide resolved
...portal/src/test/java/com/ctrip/framework/apollo/portal/util/AuthUserPasswordCheckerTest.java
Outdated
Show resolved
Hide resolved
WillardHu
force-pushed
the
feat/issue-4018
branch
from
6f31393
to
538199f
Compare
nobodyiam
reviewed
Jan 15, 2022
...portal/src/test/java/com/ctrip/framework/apollo/portal/util/AuthUserPasswordCheckerTest.java
Outdated
Show resolved
Hide resolved
Anilople
reviewed
Jan 16, 2022
| @@ -273,4 +275,12 @@ public String getAdminServiceAccessTokens() { | |||
| public boolean supportSearchByItem() { | |||
| return getBooleanProperty("searchByItem.switch", true); | |||
| } | |||
|
|
|||
| public List<String> listOfCodeFragment() { | |||
| String[] value = getArrayProperty("auth.user-password-checker.list-of-code-fragment", null); | |||
There was a problem hiding this comment.
Add the prefix to the key?
Suggested change
| String[] value = getArrayProperty("auth.user-password-checker.list-of-code-fragment", null); | |
| String[] value = getArrayProperty("apollo.portal.auth.user-password-checker.list-of-code-fragment", null); |
Or change it?
Suggested change
| String[] value = getArrayProperty("auth.user-password-checker.list-of-code-fragment", null); | |
| String[] value = getArrayProperty("apollo.portal.auth.user-password-not-allow-list", null); |
Alternative
- auth.user-password-checker.list-of-code-fragment
- apollo.portal.auth.user-password-checker.list-of-code-fragment
- apollo.portal.auth.user-password-fragment
- apollo.portal.auth.user-password-checker-fragment
- apollo.portal.auth.user-password-checker-code-fragment
- apollo.portal.auth.user-password-not-allow-list
- ...
An better key let user more understandable this feature.
Anilople
added
area/portal
WillardHu
force-pushed
the
feat/issue-4018
branch
from
538199f
to
8b3d6eb
Compare
Anilople
reviewed
Jan 17, 2022
| @@ -28,7 +29,7 @@ | |||
| private static final Pattern PWD_PATTERN = Pattern | |||
| .compile("^(?=.*[0-9].*)(?=.*[a-zA-Z].*).{8,20}$"); | |||
|
|
|||
| private static final List<String> LIST_OF_CODE_FRAGMENT = Arrays.asList( | |||
| private static final List<String> DEFAULT_USER_PASSWORD_NOT_ALLOW_LIST = Arrays.asList( | |||
There was a problem hiding this comment.
Move the default value to PortalConfig's method?
private static final List<String> DEFAULT_USER_PASSWORD_NOT_ALLOW_LIST = Arrays.asList(xxx);
public List<String> getUserPasswordNotAllowList() {
String[] value = getArrayProperty("apollo.portal.auth.user-password-not-allow-list", null);
if (value == null || value.length == 0) {
return DEFAULT_USER_PASSWORD_NOT_ALLOW_LIST;
}
return Arrays.asList(value);
}
Anilople
reviewed
Jan 17, 2022
| @@ -81,4 +80,24 @@ public void testIsWeakPassword() { | |||
| Assert.assertTrue(res.isSuccess()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testIsWeakPassword2() { | |||
There was a problem hiding this comment.
Maybe we can add more test case like return empty list, single element list?
WillardHu
force-pushed
the
feat/issue-4018
branch
from
8b3d6eb
to
5043ae3
Compare
nobodyiam
reviewed
Jan 19, 2022
...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java
Outdated
Show resolved
Hide resolved
WillardHu
force-pushed
the
feat/issue-4018
branch
from
5043ae3
to
8d529f3
Compare
Signed-off-by: WillardHu <wei.hu@daocloud.io>
WillardHu
force-pushed
the
feat/issue-4018
branch
from
8d529f3
to
27eac92
Compare
Anilople
approved these changes
Jan 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: WillardHu wei.hu@daocloud.io
What's the purpose of this PR
isCommonlyUsedpassword check not hardcodedWhich issue(s) this PR fixes:
Fixes #4018
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.