Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #4311

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix flaky test #4311

merged 1 commit into from
Apr 13, 2022

Conversation

plzdoo
Copy link
Contributor

@plzdoo plzdoo commented Apr 12, 2022

The test testReleaseBuild in class ReleaseControllerTest is flakiness due to the indeterministic iteration order of HashMap used in line 104. Changing it to LinkedHashMap can solve the problem.

Using mvn -pl apollo-adminservice edu.illinois:nondex-maven-plugin:1.1.2:nondex test -Dtest=ReleaseControllerTest#testReleaseBuild -DnondexRuns=10 can reproduce the problem.

@github-actions
Copy link

github-actions bot commented Apr 12, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@plzdoo
Copy link
Contributor Author

plzdoo commented Apr 12, 2022

I have read the CLA Document and I hereby sign the CLA

@codecov-commenter
Copy link

Codecov Report

Merging #4311 (f514768) into master (a882f3e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4311      +/-   ##
============================================
- Coverage     53.17%   53.16%   -0.01%     
+ Complexity     2668     2667       -1     
============================================
  Files           488      488              
  Lines         15253    15253              
  Branches       1577     1577              
============================================
- Hits           8111     8110       -1     
  Misses         6587     6587              
- Partials        555      556       +1     
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 84.70% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a882f3e...f514768. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 735f588 into apolloconfig:master Apr 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
@nobodyiam nobodyiam added this to the 2.0.0 milestone May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants