Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the delete appnamespace failed issue #4388

Merged

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

fix the delete appnamespace failed issue

Which issue(s) this PR fixes:

Fixes #4387

Brief changelog

  • append isDeleted = 0 condition to batch delete statements to not affected those already deleted ones.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4388 (7d50d88) into master (1cdbd14) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4388   +/-   ##
=========================================
  Coverage     53.18%   53.18%           
  Complexity     2674     2674           
=========================================
  Files           489      489           
  Lines         15277    15277           
  Branches       1580     1580           
=========================================
  Hits           8125     8125           
  Misses         6597     6597           
  Partials        555      555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdbd14...7d50d88. Read the comment docs.

@nobodyiam nobodyiam requested a review from nisiyong May 29, 2022 02:45
@nobodyiam nobodyiam added this to the 2.0.1 milestone May 29, 2022
Copy link
Member

@nisiyong nisiyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit c268745 into apolloconfig:master May 29, 2022
@nobodyiam nobodyiam deleted the fix-delete-appnamespace-issue branch May 29, 2022 03:01
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error occurred when deleting AppNamespace
3 participants