Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump okhttp3 from 3.11.0 to 4.9.3 #4392

Merged
merged 1 commit into from
Jun 4, 2022

Conversation

shoothzj
Copy link
Member

@shoothzj shoothzj commented Jun 2, 2022

What's the purpose of this PR

Sine okhttp3 3.x is not maintained, update to 4.x

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #4392 (cbc0bea) into master (40772c4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4392      +/-   ##
============================================
+ Coverage     53.15%   53.16%   +0.01%     
- Complexity     2671     2672       +1     
============================================
  Files           489      489              
  Lines         15277    15277              
  Branches       1580     1580              
============================================
+ Hits           8120     8122       +2     
+ Misses         6604     6603       -1     
+ Partials        553      552       -1     
Impacted Files Coverage Δ
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40772c4...cbc0bea. Read the comment docs.

Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam modified the milestones: 2.1.0, 2.0.1 Jun 4, 2022
@nobodyiam nobodyiam merged commit e04028d into apolloconfig:master Jun 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2022
@shoothzj shoothzj deleted the okhttp3-3-11-0-4-9-3 branch June 4, 2022 06:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants