Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor:Simplify the code #4435

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

zhangyangx
Copy link
Contributor

Signed-off-by: yang.zhang yang.zhang-iog@daocloud.io

What's the purpose of this PR

Simplify the code

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: yang.zhang <yang.zhang-iog@daocloud.io>
@codecov-commenter
Copy link

Codecov Report

Merging #4435 (460ce01) into master (471f59d) will increase coverage by 0.01%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master    #4435      +/-   ##
============================================
+ Coverage     53.39%   53.41%   +0.01%     
  Complexity     2688     2688              
============================================
  Files           490      490              
  Lines         15253    15252       -1     
  Branches       1586     1586              
============================================
+ Hits           8145     8147       +2     
+ Misses         6551     6549       -2     
+ Partials        557      556       -1     
Impacted Files Coverage Δ
.../foundation/internals/NetworkInterfaceManager.java 60.00% <40.00%> (-2.72%) ⬇️
.../ctrip/framework/apollo/core/MetaDomainConsts.java 80.72% <100.00%> (-0.23%) ⬇️
...amework/foundation/internals/ServiceBootstrap.java 94.11% <100.00%> (-0.33%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471f59d...460ce01. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 6a89ffb into apolloconfig:master Jul 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2022
@zhangyangx zhangyangx deleted the refactor/lambda branch July 2, 2022 12:11
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants