-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:关联 namespace界面,可以一次选择多个namespace #4437
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #4437 +/- ##
=========================================
Coverage 53.41% 53.42%
- Complexity 2688 2689 +1
=========================================
Files 490 490
Lines 15252 15252
Branches 1586 1586
=========================================
+ Hits 8147 8148 +1
Misses 6549 6549
+ Partials 556 555 -1
Continue to review full report at Codecov.
|
apollo-portal/src/main/resources/static/scripts/controller/NamespaceController.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a Permission Management page after the namespaces are associated. This was designed to let the user assign the permissions for the associated namespace.
However, since now we allow users to select multiple namespaces, it's not easy to let the user assign the permissions for multiple namespaces. But currently, it will display undefined as shown in the following screenshot, which is a bug. We need to adapt for this kind of scenario, e.g. if multiple namespaces are selected, simply redirect to the project page.
That's a good point. Let me revise it |
now, if user select multiple namespaces, it will redirect to the this page |
This looks fine to me. |
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@klboke please also help to take a look, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
What's the purpose of this PR
关联 namespace界面,可以一次选择多个namespace
Which issue(s) this PR fixes:
Fixes # #4329
Follow this checklist to help us incorporate your contribution quickly and easily: