Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature:关联 namespace界面,可以一次选择多个namespace #4437

Merged
merged 7 commits into from
Jul 4, 2022
Merged

feature:关联 namespace界面,可以一次选择多个namespace #4437

merged 7 commits into from
Jul 4, 2022

Conversation

falser101
Copy link
Member

@falser101 falser101 commented Jul 1, 2022

Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io

What's the purpose of this PR

关联 namespace界面,可以一次选择多个namespace

Which issue(s) this PR fixes:

Fixes # #4329

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@falser101
Copy link
Member Author

image

@klboke klboke self-requested a review July 1, 2022 10:21
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2022

Codecov Report

Merging #4437 (61353b1) into master (b229e00) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #4437   +/-   ##
=========================================
  Coverage     53.41%   53.42%           
- Complexity     2688     2689    +1     
=========================================
  Files           490      490           
  Lines         15252    15252           
  Branches       1586     1586           
=========================================
+ Hits           8147     8148    +1     
  Misses         6549     6549           
+ Partials        556      555    -1     
Impacted Files Coverage Δ
.../apollo/portal/controller/NamespaceController.java 12.22% <0.00%> (ø)
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b229e00...61353b1. Read the comment docs.

@falser101 falser101 requested a review from klboke July 1, 2022 12:30
@falser101
Copy link
Member Author

image
image

@klboke @nobodyiam

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a Permission Management page after the namespaces are associated. This was designed to let the user assign the permissions for the associated namespace.
However, since now we allow users to select multiple namespaces, it's not easy to let the user assign the permissions for multiple namespaces. But currently, it will display undefined as shown in the following screenshot, which is a bug. We need to adapt for this kind of scenario, e.g. if multiple namespaces are selected, simply redirect to the project page.

image

@falser101
Copy link
Member Author

That's a good point. Let me revise it

@falser101
Copy link
Member Author

falser101 commented Jul 2, 2022

now, if user select multiple namespaces, it will redirect to the this page
image
else if user select one namespace,it will redirect to Permission Management page
image
@nobodyiam

@falser101 falser101 requested a review from nobodyiam July 2, 2022 12:39
@falser101 falser101 changed the title feat:关联 namespace界面,可以一次选择多个namespace feature:关联 namespace界面,可以一次选择多个namespace Jul 2, 2022
CHANGES.md Outdated Show resolved Hide resolved
@nobodyiam
Copy link
Member

now, if user select multiple namespaces, it will redirect to the this page image else if user select one namespace,it will redirect to Permission Management page image @nobodyiam

This looks fine to me.

@falser101 falser101 requested a review from nobodyiam July 3, 2022 05:31
falser101 and others added 7 commits July 3, 2022 21:59
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang jianfei.zhang@daocloud.io
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Signed-off-by: jianfei.zhang <jianfei.zhang@daocloud.io>
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@klboke please also help to take a look, thx.

Copy link
Contributor

@klboke klboke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klboke klboke merged commit 804ffae into apolloconfig:master Jul 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2022
@falser101 falser101 added the feature Categorizes issue as related to a new feature. label Jul 28, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Categorizes issue as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants