Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Ctrip related codes #4448

Merged
merged 40 commits into from
Jul 7, 2022
Merged

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jul 6, 2022

What's the purpose of this PR

Clean up Ctrip related codes

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from nobodyiam July 6, 2022 06:41
@codecov-commenter
Copy link

Codecov Report

Merging #4448 (2b747f7) into master (5ab705d) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4448      +/-   ##
============================================
+ Coverage     53.44%   53.51%   +0.07%     
+ Complexity     2692     2689       -3     
============================================
  Files           490      488       -2     
  Lines         15267    15229      -38     
  Branches       1588     1587       -1     
============================================
- Hits           8159     8150       -9     
+ Misses         6552     6523      -29     
  Partials        556      556              
Impacted Files Coverage Δ
...m/ctrip/framework/apollo/biz/config/BizConfig.java 26.78% <ø> (+0.92%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.24% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab705d...2b747f7. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 44c192d into apolloconfig:master Jul 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants