Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test case NamespaceServiceTest.testFindNamespace() #4491

Merged
merged 31 commits into from
Jul 31, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jul 30, 2022

Which issue(s) this PR fixes:

Fixes #4490

klboke and others added 30 commits May 16, 2019 11:07
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 137, should it be someRelease or errorRelease?

  someRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\"");
  errorRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\"");

@klboke
Copy link
Contributor Author

klboke commented Jul 31, 2022

Expected to be

errorRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\"");

Code has been adjusted

@codecov-commenter
Copy link

Codecov Report

Merging #4491 (e7d1bac) into master (4272471) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4491   +/-   ##
=========================================
  Coverage     53.63%   53.63%           
  Complexity     2702     2702           
=========================================
  Files           489      489           
  Lines         15294    15294           
  Branches       1588     1588           
=========================================
  Hits           8203     8203           
  Misses         6535     6535           
  Partials        556      556           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 63c16c1 into apolloconfig:master Jul 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the kl-fix branch March 15, 2023 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NamespaceServiceTest#testFindNamespace failed frequently
3 participants