-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test case NamespaceServiceTest.testFindNamespace() #4491
Conversation
# Conflicts: # README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 137, should it be someRelease
or errorRelease
?
someRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\"");
errorRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\"");
Expected to be errorRelease.setConfigurations("\"a\":\"123\",\"b\":\"123\""); Code has been adjusted |
Codecov Report
@@ Coverage Diff @@
## master #4491 +/- ##
=========================================
Coverage 53.63% 53.63%
Complexity 2702 2702
=========================================
Files 489 489
Lines 15294 15294
Branches 1588 1588
=========================================
Hits 8203 8203
Misses 6535 6535
Partials 556 556 Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Fixes #4490