Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apollo-biz): simplify the code of ReleaseService #4502

Merged
merged 1 commit into from
Aug 6, 2022
Merged

refactor(apollo-biz): simplify the code of ReleaseService #4502

merged 1 commit into from
Aug 6, 2022

Conversation

mghio
Copy link
Contributor

@mghio mghio commented Aug 6, 2022

What's the purpose of this PR

Simplify the code of ReleaseService.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4502 (20c0452) into master (17f5961) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##             master    #4502      +/-   ##
============================================
- Coverage     53.48%   53.46%   -0.03%     
+ Complexity     2704     2702       -2     
============================================
  Files           490      490              
  Lines         15343    15344       +1     
  Branches       1596     1596              
============================================
- Hits           8206     8203       -3     
- Misses         6580     6584       +4     
  Partials        557      557              
Impacted Files Coverage Δ
...p/framework/apollo/biz/service/ReleaseService.java 71.59% <38.46%> (-1.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ec658b0 into apolloconfig:master Aug 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants