Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to custom oidc userDisplayName #4507

Merged
merged 10 commits into from
Sep 9, 2022

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Aug 10, 2022

What's the purpose of this PR

add an option for custom oidc userDisplayName claimName

Which issue(s) this PR fixes:

Fixes #3795 #4498

Brief changelog

  1. add a property spring.security.oidc.user-display-name-claim-name to custom the claimName of the userDisplayName
  2. add the getFullName as a fallback of the getPreferredUsername

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@vdiskg vdiskg requested a review from nobodyiam August 10, 2022 14:34
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #4507 (46c2c91) into master (82db184) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head 46c2c91 differs from pull request most recent head 9bcbbbb. Consider uploading reports for the commit 9bcbbbb to get more accurate results

@@             Coverage Diff              @@
##             master    #4507      +/-   ##
============================================
- Coverage     53.47%   53.36%   -0.11%     
+ Complexity     2707     2704       -3     
============================================
  Files           492      494       +2     
  Lines         15393    15419      +26     
  Branches       1595     1598       +3     
============================================
- Hits           8231     8228       -3     
- Misses         6605     6634      +29     
  Partials        557      557              
Impacted Files Coverage Δ
...lo/portal/spi/configuration/AuthConfiguration.java 8.33% <0.00%> (ø)
...portal/spi/configuration/OidcExtendProperties.java 0.00% <0.00%> (ø)
...i/oidc/OidcAuthenticationSuccessEventListener.java 0.00% <0.00%> (ø)
...ork/apollo/portal/spi/oidc/OidcUserInfoHolder.java 0.00% <0.00%> (ø)
...ework/apollo/portal/spi/oidc/OidcUserInfoUtil.java 0.00% <0.00%> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0.00%> (-8.34%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.24% <0.00%> (-1.20%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 70.31% <0.00%> (+4.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam
Copy link
Member

Looks great! Shall we also add some instructions in the oidc related documents?

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also help to update the en doc

@nobodyiam
Copy link
Member

Looks great, would you please also help to update the en doc?

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nobodyiam nobodyiam merged commit cb62807 into apolloconfig:master Sep 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[使用疑问]接入oidc认证,如何把用户标识改为email
3 participants