-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an option to custom oidc userDisplayName #4507
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4507 +/- ##
============================================
- Coverage 53.47% 53.36% -0.11%
+ Complexity 2707 2704 -3
============================================
Files 492 494 +2
Lines 15393 15419 +26
Branches 1595 1598 +3
============================================
- Hits 8231 8228 -3
- Misses 6605 6634 +29
Partials 557 557
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Looks great! Shall we also add some instructions in the oidc related documents? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also help to update the en doc
docs/zh/development/portal-how-to-implement-user-login-function.md
Outdated
Show resolved
Hide resolved
Looks great, would you please also help to update the en doc? |
# Conflicts: # CHANGES.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's the purpose of this PR
add an option for custom oidc userDisplayName claimName
Which issue(s) this PR fixes:
Fixes #3795 #4498
Brief changelog
spring.security.oidc.user-display-name-claim-name
to custom the claimName of the userDisplayNamegetFullName
as a fallback of thegetPreferredUsername
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.