Refactor tryToGetClientIp method #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md
mghio
reviewed
Aug 12, 2022
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/WebUtils.java
Outdated
Show resolved
Hide resolved
mghio
reviewed
Aug 12, 2022
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/WebUtils.java
Outdated
Show resolved
Hide resolved
nobodyiam
reviewed
Aug 13, 2022
apollo-common/src/main/java/com/ctrip/framework/apollo/common/utils/WebUtils.java
Outdated
Show resolved
Hide resolved
…utils/WebUtils.java Co-authored-by: Jason Song <nobodyiam@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4514 +/- ##
============================================
- Coverage 53.46% 53.42% -0.05%
+ Complexity 2706 2702 -4
============================================
Files 491 492 +1
Lines 15399 15393 -6
Branches 1596 1595 -1
============================================
- Hits 8233 8223 -10
- Misses 6607 6610 +3
- Partials 559 560 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…utils/WebUtils.java Co-authored-by: mghio <43461943+mghio@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
Refactor
tryToGetClientIpmethod