Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ItemSetService(updateSet Item) and ConfigChangeContentBuilder a little bit #4515

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

mghio
Copy link
Contributor

@mghio mghio commented Aug 12, 2022

What's the purpose of this PR

Refactor ItemSetService(updateSet Item) and ConfigChangeContentBuilder a little bit.

Brief changelog

Refactor ItemSetService(updateSet Item) and ConfigChangeContentBuilder a little bit.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2022

Codecov Report

Merging #4515 (186db81) into master (93e557e) will decrease coverage by 0.01%.
The diff coverage is 12.19%.

@@             Coverage Diff              @@
##             master    #4515      +/-   ##
============================================
- Coverage     53.47%   53.45%   -0.02%     
  Complexity     2705     2705              
============================================
  Files           491      491              
  Lines         15395    15399       +4     
  Branches       1599     1596       -3     
============================================
  Hits           8232     8232              
- Misses         6603     6607       +4     
  Partials        560      560              
Impacted Files Coverage Δ
...apollo/adminservice/controller/ItemController.java 7.29% <0.00%> (+0.14%) ⬆️
...p/framework/apollo/biz/service/ItemSetService.java 8.95% <0.00%> (-0.89%) ⬇️
...k/apollo/biz/utils/ConfigChangeContentBuilder.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2ab923f into apolloconfig:master Aug 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants