Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration processor for portal developers #4521

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Aug 15, 2022

What's the purpose of this PR

like #3553
offer the IDE code completion of the ldap and oidc configuration

Brief changelog

add the dependency spring-boot-configuration-processor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

Codecov Report

Merging #4521 (839b1c9) into master (2ab923f) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4521      +/-   ##
============================================
- Coverage     53.46%   53.43%   -0.04%     
  Complexity     2706     2706              
============================================
  Files           491      492       +1     
  Lines         15399    15393       -6     
  Branches       1596     1595       -1     
============================================
- Hits           8233     8225       -8     
- Misses         6607     6610       +3     
+ Partials        559      558       -1     
Impacted Files Coverage Δ
...ework/apollo/internals/RemoteConfigRepository.java 85.27% <0.00%> (-3.07%) ⬇️
...work/apollo/biz/message/ReleaseMessageScanner.java 82.89% <0.00%> (-2.64%) ⬇️
...mework/apollo/openapi/service/ConsumerService.java 58.46% <0.00%> (ø)
.../ctrip/framework/apollo/common/utils/WebUtils.java 100.00% <0.00%> (ø)
...configservice/controller/ConfigFileController.java 84.40% <0.00%> (+0.92%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️
...llo/configservice/controller/ConfigController.java 97.46% <0.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam nobodyiam force-pushed the portal-configuration-processor branch from 839b1c9 to 948541f Compare August 19, 2022 00:23
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit dfbffe5 into apolloconfig:master Aug 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants